Make (unstable API) UniqueRc invariant for soundness
#135379
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
steffahn
force-pushed
the
uniquerc-invariant
branch
from
b1b00a1 to
df57d65
Compare
5 tasks
|
lol, triagebot auto-rolled someone from compiler bc of the ui test r? libs cc @eholk @Mark-Simulacrum (for the original pr) |
|
@bors r+ Seems right. |
bors
added
S-waiting-on-bors
|
Yeah, this is definitely right. Conceptually this is like having a mutex that you can pre-reserve a read guard. |
jhpratt
added a commit
to jhpratt/rust
that referenced
this pull request
Jan 12, 2025
…k-Simulacrum Make (unstable API) `UniqueRc` invariant for soundness Add test case from rust-lang#133572 (comment) (comment in review of `UniqueArc`), and fix the issue for `UniqueRc`.
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 12, 2025
Rollup of 5 pull requests Successful merges: - rust-lang#132232 (CI: build FreeBSD artifacts on FreeBSD 13.4) - rust-lang#135266 (Remove emsdk version update from 1.84.0 relnotes) - rust-lang#135364 (Cleanup `suggest_binding_for_closure_capture_self` diag in borrowck) - rust-lang#135375 (allow rustdoc-js tests to be run at stage0) - rust-lang#135379 (Make (unstable API) `UniqueRc` invariant for soundness) r? `@ghost` `@rustbot` modify labels: rollup
|
Do we have a corresponding test for |
|
We don’t have |
|
Ah. :) I didn't realize this is an |
|
I should have added a “…yet”. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add test case from #133572 (comment) (comment in review of
UniqueArc), and fix the issue forUniqueRc.